rewrite events handling to remove watermill #130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikemrm
force-pushed
the
rewrite-events
branch
22 times, most recently
from
5ec2e6e
to
21ff6c8
Compare
tylerauerbeck
previously requested changes
Jul 28, 2023
mikemrm
force-pushed
the
rewrite-events
branch
2 times, most recently
from
7a3f02c
to
dc58087
Compare
mikemrm
requested review from
a team,
nicolerenee and
sfunkhouser
as code owners
adammohammed
reviewed
Aug 3, 2023
adammohammed
reviewed
Aug 3, 2023
mikemrm
force-pushed
the
rewrite-events
branch
4 times, most recently
from
29a1c2c
to
a7b127e
Compare
jnschaeffer
reviewed
Aug 3, 2023
As discussed in the community call, watermill doesn't give us the necessary features we'd like to utilize with the underlying nats message. We decided to switch to using nats directly but still wanted some support for possibly changing this out later. This rewrites events to use our own interfaces to allow for the possibility of a different event driver later. Additionally this switches to using pull subscriptions instead of push, supports Ack, Nak and Term as well as Request/Reply semantics. Due to the Request/Reply semantics, no longer are there separate Publisher and Subscriber configurations as the driver needs to be able to handle both. Signed-off-by: Mike Mason <mimason@equinix.com>
Signed-off-by: Mike Mason <mimason@equinix.com>
Signed-off-by: Mike Mason <mimason@equinix.com>
Signed-off-by: Mike Mason <mimason@equinix.com>
…ers to check Signed-off-by: Mike Mason <mimason@equinix.com>
Signed-off-by: Mike Mason <mimason@equinix.com>
jnschaeffer
approved these changes
Aug 4, 2023
mikemrm
dismissed
tylerauerbeck’s stale review
notified tyler, changes already applied
fishnix
approved these changes
Aug 4, 2023
rizzza
approved these changes
Aug 4, 2023
sfunkhouser
approved these changes
Aug 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in the community call, watermill doesn't give us the necessary features we'd like to utilize with the underlying nats message. We decided to switch to using nats directly but still wanted some support for possibly changing this out later.
This rewrites events to use our own interfaces to allow for the possibility of a different event driver later.
Additionally this switches to using pull subscriptions instead of push, supports Ack, Nak and Term as well as Request/Reply semantics.
Due to the Request/Reply semantics, no longer are there separate Publisher and Subscriber configurations as the driver needs to be able to handle both.