Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(OH2-366): restrict userName characters #646

Merged
merged 1 commit into from
Sep 2, 2024
Merged

fix(OH2-366): restrict userName characters #646

merged 1 commit into from
Sep 2, 2024

Conversation

gasp
Copy link
Contributor

@gasp gasp commented Aug 7, 2024

OH2-366

restrict userName characters
username-test

@gasp gasp changed the title fix: restrict userName characters fix(OH2-366): restrict userName characters Aug 7, 2024
@mwithi mwithi requested a review from SilverD3 August 8, 2024 19:57
SilverD3
SilverD3 reviewed Aug 9, 2024
View reviewed changes
Copy link
Contributor

@SilverD3 SilverD3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/components/accessories/admin/users/newUser/validation.test.ts Show resolved Hide resolved
@SilverD3
Copy link
Contributor

SilverD3 commented Aug 9, 2024 •
edited
Loading

I recognize that this comment doesn't fall within the scope of this PR, but I just noticed this possible design improvement.
User Forml

  1. password and confirmPassword fields can be on the line (two columns grid).
  2. description should be a textarea

@gasp gasp requested a review from SilverD3 August 29, 2024 13:45
mwithi
mwithi approved these changes Sep 2, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved by @SilverD3

@mwithi mwithi merged commit 60f88c1 into informatici:develop Sep 2, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwithi mwithi mwithi approved these changes

@SilverD3 SilverD3 Awaiting requested review from SilverD3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gasp @SilverD3 @mwithi