Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(oh2-299): new user form #621

Merged
merged 13 commits into from
Jul 24, 2024
Merged

feat(oh2-299): new user form #621

merged 13 commits into from
Jul 24, 2024

Conversation

gasp
Copy link
Contributor

@gasp gasp commented Jun 24, 2024 •
edited by jira bot
Loading

@gasp gasp marked this pull request as ready for review July 8, 2024 22:39
@mwithi mwithi requested a review from SilverD3 July 9, 2024 09:23
@gasp gasp force-pushed the feature/OH2-299-admin-user-create branch 2 times, most recently from 352fb2e to c218811 Compare July 9, 2024 10:26
@gasp gasp force-pushed the feature/OH2-299-admin-user-create branch from c218811 to 57597f1 Compare July 9, 2024 10:26
SteveGT96
SteveGT96 suggested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@SteveGT96 SteveGT96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, could you also add feedback dialog wether the operation succeeds or not ? (just like you've done for the Exam Form).

@gasp
Copy link
Contributor Author

gasp commented Jul 12, 2024

Thanks for the review, here is how it looks like.

created

@gasp gasp requested a review from SteveGT96 July 12, 2024 13:22
@SilverD3
Copy link
Contributor

LGTM!

In the mock, we have description field, but I can see it in the form you provided.

@gasp
Copy link
Contributor Author

gasp commented Jul 15, 2024

Here is the user description, sorry for omitting the field!

Screen Recording 2024-07-15 at 15 13 47

SilverD3
SilverD3 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@SilverD3 SilverD3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working and tests are passing!

@mwithi
Copy link
Member

mwithi commented Jul 16, 2024 •
edited
Loading

shouldn't the password be retyped twice?

@mwithi
Copy link
Member

mwithi commented Jul 16, 2024

Also, the group field shows the groups' descriptions but not the groups' names

image

We could show them as "name - description" I guess...

image

@gasp
Copy link
Contributor Author

gasp commented Jul 16, 2024

shouldn't the password be retyped twice?

Good idea, it shall reduce typing errors

@gasp
Copy link
Contributor Author

gasp commented Jul 16, 2024

shouldn't the password be retyped twice?
Also, the group field shows the groups' descriptions but not the groups' names
We could show them as "name - description" I guess.

  • Password should be retyped twice
  • group selector now displays "code - description"

Screen Recording 2024-07-16 at 14 00 10

@gasp
Copy link
Contributor Author

gasp commented Jul 16, 2024

Small detail: autocomplete matches code or description
Screen Recording 2024-07-16 at 14 09 54

@gasp gasp force-pushed the feature/OH2-299-admin-user-create branch from 68713f4 to a933b46 Compare July 16, 2024 12:14
@mwithi
Copy link
Member

mwithi commented Jul 19, 2024

User creation is ok. If User already exists the error message is not defined (we need to improve api though)

image

@gasp gasp force-pushed the feature/OH2-299-admin-user-create branch from 5cbd232 to aba8261 Compare July 22, 2024 09:56
@mwithi
Copy link
Member

mwithi commented Jul 22, 2024 •
edited
Loading

I think that on the NEW USER page, we should also have a CANCEL button, and in case of error saving the USER (the message is ok now) it should not go back to the list but remain on the edit page

mwithi
mwithi approved these changes Jul 24, 2024
View reviewed changes
Copy link
Member

@mwithi mwithi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved to move on with next developments

@mwithi mwithi merged commit 6e52676 into informatici:develop Jul 24, 2024
3 checks passed
gasp added a commit to gasp/openhospital-ui that referenced this pull request Jul 24, 2024
@gasp
feat(oh2-299): new user form (informatici#621)
e85736e 
* feat(oh2-299): new user form

* feat: use UserGroupDTO as the form type rule

* feat: reset form

* feat: add user to backend and redirect

* feat: wait for the user to be saved before changing page

* feat: add translations to validations

* fix: customize username validation message

* fix: validation strings & touched

* feat: add success modal

* fix: added user description

* feat: confirm password

* fix: error message + icon

* fix: cancel instead of reset + error goes back to form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwithi mwithi mwithi approved these changes

@SilverD3 SilverD3 SilverD3 approved these changes

@SteveGT96 SteveGT96 Awaiting requested review from SteveGT96

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gasp @SilverD3 @mwithi @SteveGT96