Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OP-1206 Review docker usage documentation in oh-api #465

Merged
merged 8 commits into from
Sep 10, 2024

Conversation

mwithi
Copy link
Member

@mwithi mwithi commented Sep 6, 2024

Copy link
Collaborator

@dbmalkovsky dbmalkovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just have time to review the changes but not to actually test anything.
My "review" LGTM.

@mwithi
Copy link
Member Author

mwithi commented Sep 6, 2024

I just have time to review the changes but not to actually test anything. My "review" LGTM.

it need some tests indeed, no hurry by the way. Thanks!

@mwithi
Copy link
Member Author

mwithi commented Sep 9, 2024

@emecas I did many tests, also from my phone as a client in the LAN and it works fine for me. To test is enough (following the README) to copy dotenv -> .env and set any value, it should work smoothly.
Let me know! Thanks!

@mwithi mwithi merged commit 323d3d8 into develop Sep 10, 2024
4 checks passed
@mwithi mwithi deleted the OP-1206-review-docker-usage-documentation-in-oh-api branch September 10, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants