Add minimal example, remove creopyson test #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicogene
reviewed
Feb 5, 2024
src/creo2urdf/src/Utils.cpp
Outdated
| * - The first element is a boolean indicating success (true) or failure (false). | ||
| * - The second element is an iDynTree::Direction representing the unit vector of the specified axis | ||
| * transformed into the coordinate system of the specified link frame. If the operation fails, | ||
| * this vector will be zero-initialized. | ||
| */ |
There was a problem hiding this comment.
I would move the doxygen documentation to the Utils.h, if I recall correctly the doxyfile has a filter for getting only the .h/.hpp
There was a problem hiding this comment.
removed it from the cpp, for some reason it was there.
| } | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
This is not used anywhere since we refactored the code for using the ElementTree right?
Nicogene
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a Hello World example of creo2urdf by using the good old 2bars assembly. The yaml contains only the mandatory stuff.
Additionally: