Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

409 chemo dose exception #410

Merged
merged 4 commits into from
Aug 3, 2023
Merged

409 chemo dose exception #410

merged 4 commits into from
Aug 3, 2023

Conversation

hknahal
Copy link
Contributor

@hknahal hknahal commented Jul 28, 2023

Related to #409

  • Updated drugDose validation script to check that the prescribed/actual drug dose fields are not submitted when the 'chemotherapy_drug_dose_units' has an exception value of 'Not applicable'.

To test:

  • Upload program exceptions file for 'chemotherapy_drug_dose_units' = 'Not applicable'
  • Submit chemotherapy table where 'chemotherapy_drug_dose_units' = 'Not applicable'
    --> If 'prescribed_cumulative_drug_dose' and/or 'actual_cumulative_drug_dose' fields are submitted, then validation should fail.
    --> If 'prescribed_cumulative_drug_dose' and/or 'actual_cumulative_drug_dose' fields are not submitted (left empty), then validation should pass

Dictionary 1.17 merge to master
…nits' field for exception value of 'not applicable' and then check that the prescribed and actual drug dose fields are not submitted
…n value of 'not applicable' and prescribed/actual drug dose field values
@hknahal hknahal requested a review from Buwujiu July 28, 2023 22:24
@hknahal
Copy link
Contributor Author

hknahal commented Jul 31, 2023

Tested on DEV using HNAHAL-CA

Test case 1: Missing dose when dose units have been submitted
If chemotherapy_drug_dose_units has an enum submitted from the dictionary (ex. chemotherapy_drug_dose_units = mg/m2) and prescribed_cumulative_drug_dose and actual_cumulative_drug_dose fields are left empty, the validation should fail.

Result: Validation fails as expected
dev_chemo_invalid_submission

Test case 2: Dose field(s) are submitted when chemotherapy_drug_dose_units has a clinical exception value of Not applicable
If chemotherapy_drug_dose_units has a clinical exception so that chemotherapy_drug_dose_units = Not applicable, but both/either prescribed_cumulative_drug_dose and actual_cumulative_drug_dose fields are submitted, the validation should fail.

Result: Validation fails as expected
dev_chemo_invalid_when_exception

@Buwujiu
Copy link
Contributor

Buwujiu commented Jul 31, 2023

Tested in Dev HNAHAL-CA, working as expected!

@hknahal hknahal changed the base branch from master to develop July 31, 2023 20:13
@hknahal hknahal merged commit 742f767 into develop Aug 3, 2023
1 check passed
@justincorrigible justincorrigible deleted the 409_chemo_dose_exception branch October 31, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants