Graph widget to show historical data #4601
Conversation
![home-assistant[bot]](https://avatars.githubusercontent.com/in/97978?s=60&v=4){kind=small}
There was a problem hiding this comment.
It seems you haven't yet signed a CLA. Please do so here.
Once you do that we will be able to review and accept this pull request.
Thanks!
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
ivorsmorenburg
changed the title
home-assistant
bot
added
cla-recheck
cla-signed
and removed
cla-recheck
cla-needed
labels
jpelgrom
changed the title
…/issue-1529 # Conflicts: # app/src/main/java/io/homeassistant/companion/android/settings/widgets/ManageWidgetsViewModel.kt
|
Hi Ivor, can you add a small video demo the functionality? |
common/src/main/java/io/homeassistant/companion/android/database/sensor/SensorDao.kt
Show resolved
Hide resolved
Yes we could but I didn't see that as an requirement for the 4 hours test. I want to optimise this piece of code before it gets merged. |
This is the video example of an MVP for the GraphWidget graphwidget_mvp_example.mp4 |
app/src/main/java/io/homeassistant/companion/android/settings/widgets/ManageWidgetsViewModel.kt
Outdated
Show resolved
Hide resolved
...src/main/java/io/homeassistant/companion/android/settings/widgets/views/ManageWidgetsView.kt
Outdated
Show resolved
Hide resolved
|
@ivorsmorenburg can you please add some screenshots of the configuration page so we can see what options the user needs to use? For example I can see the code contains stuff related to entity attributes but I am not sure if those are even used in the graph? |
Yes you are correct, right now is just an MVP, the UI Config Screen is the Entity UI Screen. I'll work on it no worries : ) I have big plans for the UI |
|
ok thanks for confirming :) sometimes when a PR is in draft its tough to tell how much to look and comment 🙈 I will go ahead and look at the generated APK for now until you feel the code is ready to look at :) |
.../src/main/java/io/homeassistant/companion/android/database/widget/graph/GraphWidgetEntity.kt
Outdated
Show resolved
Hide resolved
.../src/main/java/io/homeassistant/companion/android/database/widget/graph/GraphWidgetEntity.kt
Outdated
Show resolved
Hide resolved
ivorsmorenburg
force-pushed
the
feature/issue-1529
branch
from
04c9aa2
to
02c57d5
Compare
|
@ivorsmorenburg this PR has a lot going on with just the logic for Graph Widget alone and I dont think a lot of that we can escape. There are other things done in this PR that are touching other widgets thats making this a bit difficult to not only review but also test and make sure the other widgets are still fine. Can you please split up the refactoring of the other widgets so we can review it separately and make the review of this PR easier? That should help cut down on the amount of files touched and make this PR easier to review. We can review that PR before this one as I think you may have some dependencies on it. |
Summary
Adds Graph Widget to make possible see historical data
Screenshots
#1529 (comment)
Link to pull request in Documentation repository
Documentation: home-assistant/companion.home-assistant#
Any other notes
#1529