DOCS-903: add dependencies and POJO tip; backport type-name #1297
Conversation
oliverhowell
added
backport to 5.3
✅ Deploy Preview for hardcore-allen-f5257d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
docs/modules/mapstore/pages/configuring-a-generic-mapstore.adoc
Outdated
Show resolved
Hide resolved
|
|
||
| When you configure a map with the generic MapLoader, Hazelcast creates a xref:sql:mapping-to-jdbc.adoc[SQL mapping with the JDBC connector]. The name of the mapping is the same name as your map prefixed with `__map-store.`. This mapping is used to read data from the external system, and it is removed whenever the configured map is removed. You can also configure this SQL mapping, using <<data-connection-ref, configuration properties>>. | ||
|
|
||
| == Configuration Properties for the Generic MapLoader | ||
| == Configuration properties for the generic MapLoader |
There was a problem hiding this comment.
| == Configuration properties for the generic MapLoader | |
| == Configuration properties for the Generic MapLoader |
There was a problem hiding this comment.
And is generic mapStore correct then?
There was a problem hiding this comment.
No, IMHO should have the same case. This case is used also in the title btw.
There was a problem hiding this comment.
I've looked at the other sources and I think we should refer to "generic MapLoader" in normal text. I know in code it is "Generic.MapLoader" and we use that when specifically including or referring to code (if we always used code names then our docs and marketing content would be all over the place). Check latest commit for proposed version.
docs/modules/mapstore/pages/configuring-a-generic-mapstore.adoc
Outdated
Show resolved
Hide resolved
docs/modules/mapstore/pages/configuring-a-generic-maploader.adoc
Outdated
Show resolved
Hide resolved
| == Quickstart Configuration | ||
| == Add dependencies | ||
|
|
||
| If you are using a Hazelcast JAR file, you need to ensure you have added the following dependencies to your pom.xml: |
There was a problem hiding this comment.
Better wording would be that they need to be on the classpath. E.g. if you use the full docker image they are. If you use the slim image the hazelcast-mapstore is missing.
Also the section Supported backends below also mentions that you need jdbc driver or in case of using MongoDB you need the hazelcast-jet-mongodb jar. Maybe this could be unified into single place.
There was a problem hiding this comment.
Like this?
| If you are using a Hazelcast JAR file, you need to ensure you have added the following dependencies to your pom.xml: | |
| If you are using a Hazelcast JAR file, you need to ensure the following is added to your classpath: | |
| NOTE: If you are using the slim distribution, you need to add `hazelcast-mapstore`. If you are using MongoDb, you also need to add `hazelcast-jet-mongodb`. |
Closes SUP-455 and DOCS-903