Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eth_call, eth_getLogs and eth_estimateGas coverage to conformity tests #2953

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

natanasow
Copy link
Collaborator

@natanasow natanasow commented Sep 9, 2024

Description:

Add eth_call, eth_getLogs and eth_estimateGas test to conformity tests:

  • eth_call - non existing contract
  • eth_call - existing contract view function and existing from
  • eth_call - existing contract tx and existing from
  • eth_call - existing contract tx, existing from and positive value
  • eth_call - existing contract view function and non-existing from
  • eth_call - existing contract tx and non-existing from
  • eth_call - existing contract tx, non-existing from and positive value
  • eth_estimateGas - non existing contract
  • eth_estimateGas - existing contract view function and existing from
  • eth_estimateGas - existing contract tx and existing from
  • eth_estimateGas - existing contract tx, existing from and positive value
  • eth_estimateGas - existing contract view function and non-existing from
  • eth_estimateGas - existing contract tx and non-existing from
  • eth_estimateGas - existing contract tx, non-existing from and positive value
  • eth_getLogs - non-existing contract
  • eth_getLogs - existing contract
  • eth_getLogs - existing contract and from/to block

Related issue(s):

Fixes #2754

Depends on:
hashgraph/hedera-mirror-node#9302

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: nikolay <n.atanasow94@gmail.com>
@natanasow natanasow self-assigned this Sep 9, 2024
@natanasow natanasow added this to the 0.56.0 milestone Sep 9, 2024
@natanasow natanasow added the enhancement New feature or request label Sep 9, 2024
Copy link

sonarcloud bot commented Sep 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
62.2% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

github-actions bot commented Sep 9, 2024

Acceptance Tests

  16 files  213 suites   28m 53s ⏱️
601 tests 597 ✔️ 4 💤 0
617 runs  613 ✔️ 4 💤 0

Results for commit 4300e69.

Copy link

github-actions bot commented Sep 9, 2024

Tests

       3 files     272 suites   20s ⏱️
1 275 tests 1 274 ✔️ 1 💤 0
1 287 runs  1 286 ✔️ 1 💤 0

Results for commit 4300e69.

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.32%. Comparing base (559285b) to head (4300e69).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2953      +/-   ##
==========================================
- Coverage   84.39%   84.32%   -0.07%     
==========================================
  Files          40       56      +16     
  Lines        3057     3771     +714     
  Branches      632      771     +139     
==========================================
+ Hits         2580     3180     +600     
- Misses        276      353      +77     
- Partials      201      238      +37     
Flag Coverage Δ
relay 84.39% <ø> (ø)
server 83.05% <ø> (?)
ws-server 97.87% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 16 files with indirect coverage changes

@quiet-node quiet-node modified the milestones: 0.56.0, 0.57.0 Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add eth_call, eth_getLogs and eth_estimateGas test to conformity tests
2 participants