Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[+] PASSIVE_WINDOWS_DETECT #476

Merged
merged 2 commits into from
Sep 2, 2024
Merged

[+] PASSIVE_WINDOWS_DETECT #476

merged 2 commits into from
Sep 2, 2024

Conversation

aleff-github
Copy link
Contributor

No description provided.

@hak5peaks
Copy link
Member

Thank you for updating your old scripts and adding windows passive detect, while I was reviewing the changes I noticed lines 118,120 and 122 are using DOWN_ARROW which is improper and will create a compiling error, could you go and change these lines to DOWNARROW or DOWN?

Thanks

@hak5peaks hak5peaks added the pending requested changes requires changes before merge label Aug 30, 2024
@aleff-github
Copy link
Contributor Author

aleff-github commented Sep 2, 2024 •
edited
Loading

@hak5peaks solved DOWNARROW error

by the way, I just created a new pull request[1] where there are similar improvements on all the payloads that I created in the past

[1] #477

@hak5peaks
Copy link
Member

Thank you, Ill check it out soon

@hak5peaks hak5peaks merged commit 0bebb44 into hak5:master Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pending requested changes requires changes before merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleff-github @hak5peaks