Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allocate set%ffnb dynamically. #1105

Merged
merged 2 commits into from
Sep 19, 2024
Merged

Allocate set%ffnb dynamically. #1105

merged 2 commits into from
Sep 19, 2024

Conversation

Thomas3R
Copy link
Contributor

@Thomas3R Thomas3R commented Sep 18, 2024

The array used for the adjustment of the GFN-FF neighbor list (set%ffnb) is now allocated dynamically.
The first dimension is always the maximum number of neighbors allowed in GFN-FF (42 since 6.7.1) and the second dimension is the number of atoms that the neighbor list should be adjusted for.

@marcelmbn marcelmbn added method: GFN-FF Related to the GFN-FF method refactor Enhancing and optimizing source code for improved readability, maintainability, and performance labels Sep 18, 2024
@marcelmbn marcelmbn linked an issue Sep 18, 2024 that may be closed by this pull request
Copy link
Member

@marcelmbn marcelmbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just commit the "style" suggestion and resolve the single question, then it should be good to go!

src/set_module.f90 Outdated Show resolved Hide resolved
src/gfnff/gfnff_ini.f90 Show resolved Hide resolved
Co-authored-by: Marcel Mueller <marcel.mueller@thch.uni-bonn.de>
Copy link
Member

@marcelmbn marcelmbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@marcelmbn marcelmbn merged commit 43a0e4e into grimme-lab:main Sep 19, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
method: GFN-FF Related to the GFN-FF method refactor Enhancing and optimizing source code for improved readability, maintainability, and performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let ffnb have a dynamic size
2 participants