Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker rebase #167

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Docker rebase #167

wants to merge 1 commit into from

Conversation

arcivanov
Copy link

Allows to rebase docker image on another parent. v2 support only (no means to test on v1).

@arcivanov arcivanov force-pushed the docker_rebase branch 17 times, most recently from eddbdbb to 824361c Compare April 6, 2018 09:01
@arcivanov
Copy link
Author

@goldmann ping?

@goldmann
Copy link
Owner

Sorry I did not reply before. I'm pretty overloaded in the last months actually and this makes reviewing such contributions pretty tricky. I'm happy to have something like this added. his would need to be scheduled for next (major/minor) version. I did not plan to release anything new and have only bugfixes added since the codebase is pretty stable and there is not much to do with it, but it looks like I'm wrong.

But thanks for the contribution, I'm happy to add it. After skimming the code it looks very good, but I haven't reviewed it in details yet, sorry!

Would it be possible to write a short doc in the docs/ directory about this feature?

I guess I should add a note to myself to generally speaking, write some documentation :)

@arcivanov
Copy link
Author

Sorry I didn't see your reply for some reason. I will for sure write a doc. Thanks!

Allows to rebase docker image on another parent. v2 support only (no means to test on v1).
@rnc
Copy link
Collaborator

rnc commented Feb 15, 2024

@arcivanov If you can fix the conflicts and rebase then I'll take care of reviewing/merging it.

@arcivanov
Copy link
Author

Ha! I stopped using it several years ago... Let me see how much work that is...

@rnc
Copy link
Collaborator

rnc commented Feb 15, 2024

@arcivanov Understood. And apologies for the gigantic delay in this. I've started trying to review and solve some of the older issues and ensure it is still supported and working (primarily for https://github.com/cekit/cekit/ )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants