Fix bug in getting merged pull request by commit #32079
Open
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/S
github-actions
bot
added
modifies/api
lunny
approved these changes
Sep 19, 2024
GiteaBot
added
lgtm/need 1
|
Maybe we can say it's just a documentation problem. The implementation hasn't been changed. So I marked it as backportable. |
lunny
reviewed
Sep 20, 2024
| @@ -325,11 +325,11 @@ func DownloadCommitDiffOrPatch(ctx *context.APIContext) { | |||
| } | |||
| } | |||
|
|
|||
| // GetCommitPullRequest returns the pull request of the commit | |||
| // GetCommitPullRequest returns the merged pull request of the commit | |||
| func GetCommitPullRequest(ctx *context.APIContext) { | |||
| // swagger:operation GET /repos/{owner}/{repo}/commits/{sha}/pull repository repoGetCommitPullRequest | |||
There was a problem hiding this comment.
Suggested change
| // swagger:operation GET /repos/{owner}/{repo}/commits/{sha}/pull repository repoGetCommitPullRequest | |
| // swagger:operation GET /repos/{owner}/{repo}/commits/{ref}/pull repository repoGetCommitPullRequest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #32027
This is actually a bug. But I'm worried that some users are already using this API to get unmerged PRs, and fixing it might be a breaking change.