Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting of IBC ExistingSessionDetectedAction via env var #147

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

kfiroo
Copy link
Contributor

@kfiroo kfiroo commented Aug 17, 2024

As suggested here #142
Added environment variable EXISTTING_SESSION_DETECTED_ACTION with default value in docker-compose.yml for setting the IBC action upon existing session.

Current default value is primary to preserve current behavior.

@gnzsnz I think I updated all the relevant files - let me know if anything is missing 🙏🏼

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@gnzsnz gnzsnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please perform the changes highlighted on my comments.

thanks a lot for your contribution.

@kfiroo kfiroo requested a review from gnzsnz August 18, 2024 12:40
Copy link
Owner

@gnzsnz gnzsnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are good to go 👍

@gnzsnz gnzsnz merged commit c226691 into gnzsnz:master Aug 19, 2024
2 checks passed
@kfiroo kfiroo mentioned this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants