PB-1000 : add support for local GeoTIFF import #1066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
feat-PB-1000-geotiff-support
|
| Run status |
|
| Run duration | 05m 06s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
21
|
Skipped
|
0
|
Passing
|
210
|
| View all changes introduced in this branch ↗︎ | |
pakb
force-pushed
the
feat-PB-1000-geotiff-support
branch
from
5bfb6a0
to
d4809e8
Compare
ltshb
reviewed
Sep 16, 2024
|
Some GeoTIFF can be found here : https://data.geo.admin.ch/browser/#/collections/ch.swisstopo.swissimage-dop10 |
ltshb
reviewed
Sep 17, 2024
There was a problem hiding this comment.
@pakb The data.geo.admin.ch link that you provide was a link to the stac browser pointing to whole collections, not a link to a STAC asset file, that's why you could not import it. Using the following link https://data.geo.admin.ch/ch.swisstopo.swissimage-dop10/swissimage-dop10_2017_2517-1139/swissimage-dop10_2017_2517-1139_0.1_2056.tif I had an issue, the import tool say successfull but I had a crash in the console and the file was not loaded
online GeoTIFF requires some work done on service-proxy, as it currently answers with 413 Payload Too Large (obviously...) I've tested with a Dropbox link (hence the use of the proxy). I couldn't get our STAC API to give me a file (through a URL import), it blocks somewhere (maybe on purpose, so that we don't use our STAC API as a web hosting)
instead of relying only on the file extension, will be more robust, and take into account .tif, .tiff (both as a mix of uppercased) and files without extension that are TIFF underneath
pakb
force-pushed
the
feat-PB-1000-geotiff-support
branch
from
7c74796
to
2ab3ca7
Compare
pakb
force-pushed
the
feat-PB-1000-geotiff-support
branch
from
2ab3ca7
to
8249eb8
Compare
adding the new type in the layer parser also fixing loading GeoTIFF through URL in the OL component. removing big-endian signature check, as 99.9% of hardware on the web uses little-endian removing the concept of GeoTIFF layer needing to load, they are either already loaded because local file, or will be loaded through the OpenLayers component (not by us, so no need to keep track of that in the menu)
pakb
force-pushed
the
feat-PB-1000-geotiff-support
branch
from
5c60375
to
758d420
Compare
and also react to changes in the source of the GeoTIFF (if the URL is changed on-the-fly)
pakb
force-pushed
the
feat-PB-1000-geotiff-support
branch
from
758d420
to
b988b95
Compare
ltshb
reviewed
Sep 19, 2024
|
here a couple GeoTIFF out of bounds can be found https://download.osgeo.org/geotiff/samples/zi_imaging/ |
ltshb
approved these changes
Sep 19, 2024
pakb
force-pushed
the
feat-PB-1000-geotiff-support
branch
from
2156d12
to
270eb78
Compare
also adding GeoTIFF to all labels linked to the file import UI (and KMZ that was forgotten) awaiting the handleFileContent in the drag&drop handler, so that error can be caught correctly (and shown to the user)
pakb
force-pushed
the
feat-PB-1000-geotiff-support
branch
from
270eb78
to
dbcc4e7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
online GeoTIFF requires some work done on
service-proxy, as it currently answers with413 Payload Too Large(obviously...)I've tested with a Dropbox link (hence the use of the proxy).
Test link with a GeoTIFF already added from STAC
Test link