New Release v1.46.0 - #minor #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync dev branch to master
PB-666: Upgrade to OpenLayers v10.
supporting API3, WMS and WMTS base URL overrides. Changing calls to functions using these base URLs from the config.js so that they now prioritize the debug value if defined.
named like they were in the mf-geoadmin3's code
it otherwise creates a circular dependency and some part of the tests can't load properly (LV95 is imported from config.js, which requires something in utils.js, which requires something in config.js, etc...)
Trying to gather common config together in a meaningfully named config file. Adding function to get base URLs, instead of direct access to constants. So that we have the opportunity to override base URLs. I didn't want to go through the store to do that. Doing so would create a lot of circular dependencies between the store, the config and components. As it's a debug tool, that's "good enough" this way.
moving slash enforcing function back to where other base URLs are in the config
and only export/share function to access them. Also clearing the layers config cache whenever a base URL changes. Changing the API3 URL would not trigger a new layer config load without that.
PB-871 : add debug UI and URL params to override URLs used by data integration team - #minor
PB-807: Do not use conflict resolution in text printing and adjust font size.
PB-735: Replace dl=0 to dl=1 for dropbox direct download
There's no RM version of the page, so we fall back to DE for that link
…r-link PB 898 Fix rumantsch footer link to geo.admin.ch - #patch
Make it more concise in order to use it also on smaller screen. For device orientation we will need a new button, so we need to make some room to avoid having the button off screen. Also removed useless 3d debugs, they are now in the regular menu.
The initial geolocation might be invalid which creates a crash error, so we avoid it.
Not all devices uses the same orientation events, therefore added both.
We had some case with infinite loop due to heading wrapping in 3D where cesium reported heading 360 which was wrapped to 0 and triggered a dispatch and a fly to which reported then back 360....
This kind of annoying especially if you want to recenter but keep your zoom.
Re-centering on position in 3D is more complex as in 2d because the of the camera. If the pitch is not 90° then we need to compute the camera position in order to have the position centered on the screen. For this moment we don't do this computation and simply don't re-center the view on geolocation by disabling geolocation tracking in 3D.
and move compass feedback to geolocation button component, linking them together visually on the UI
Keep the compass on in auto-rotation even if the map is north.
Auto rotation rotate the map using the geolocation as center and it doesn't make sense to rotate if the location is not centered (this is also the same behavior as on the swisstopo app)
we were using values from epsg.io website, but our backends use different values. I found out a project in our geoadmin organization that contained all the required values, so I copied them from there. This should fix the delta (on the Y axis) that we were experiencing when showing WMS/WMTS data with OpenLayers while showing vector tiles under
KML are well able to set that themselves if they require it, and some use cases need this to be false (flight tracks)
it was dispatching any time any URL param changed, leading to the part of the code reloading the topic/layers config being called way too often
When switching to 3D, some undefined values were set, leading to a lot of bugs (and no background tiles being added in 3D)
PB-871 : only dispatch if something has changed
web-mapviewer
|
||||||||||||||||||||||||||||
| Project |
web-mapviewer
|
| Branch Review |
develop
|
| Run status |
|
| Run duration | 01m 43s |
| Commit |
|
| Committer | Pascal Barth |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
1
|
Skipped
|
0
|
Passing
|
48
|
| View all changes introduced in this branch ↗︎ | |
ltshb
approved these changes
Sep 2, 2024
Update develop with Master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test link