Add Dockerfile #25
Merged
Add Dockerfile #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| COPY . /rust | ||
| RUN cd /rust && cargo build | ||
| CMD service redis-server start && RUST_LOG=info ./target/debug/registration_server -h 0.0.0.0 -p 4443 --cert-directory /certdir |
There was a problem hiding this comment.
We shouldn't really run redis and the server in the same docker container. Instead we should link to the redis server and use environment variables to configure. Will make a follow up issue so we're not blocking on this.
There was a problem hiding this comment.
We should also build release, not debug.
michielbdejong
force-pushed
the
dockerfile
branch
from
3e2bb6d
to
255cae3
Compare
|
Changed it to a release build, will test it on the server before merging. |
|
I left it building in a screen on the server, will update the live container to the new image when the build is done, check everything still works, then merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @samgiles