Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UPath.rename for absolute paths #225

Merged
merged 9 commits into from
Aug 23, 2024
Merged

Fix UPath.rename for absolute paths #225

merged 9 commits into from
Aug 23, 2024

Conversation

Koncopd
Copy link
Contributor

@Koncopd Koncopd commented Jun 17, 2024

@Koncopd
Copy link
Contributor Author

Koncopd commented Jun 17, 2024

This is in progress.

@petrus-v petrus-v mentioned this pull request Jul 9, 2024
Open
@ap--
Copy link
Collaborator

ap-- commented Aug 23, 2024

Hi @Koncopd

Thank you for the PR!
I made some small fixes to support webdav and smb, there is a small issue with SMBPath that has been fixed in a newer version of fsspec. I'll think about how to best fix this in here and will merge your changes.

Cheers,
Andreas

@Koncopd
Copy link
Contributor Author

Koncopd commented Aug 23, 2024

Great, thank you.

@ap-- ap-- merged commit b2eff7e into fsspec:main Aug 23, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Koncopd @ap--