Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 157: Fix D-Bus adapter tests in GitHub Actions #159

Merged
merged 5 commits into from
Jan 14, 2024

Conversation

fohrloop
Copy link
Owner

@fohrloop fohrloop commented Jan 14, 2024

Initiates a private session bus and uses that for the integration tests.

Few reasons for this:

  • In GitHub Actions, Ubuntu 22.04.3 the session bus is there, but the
    address is not available in DBUS_SESSION_BUS_ADDRESS. That is a bit
    problematic.
  • One option could have been to create a private bus and set
    os.environ['DBUS_SESSION_BUS_ADDRESS'] to that bus, but there might be
    other strategies python dbus libraries other than jeepney use for
    getting the session dbus address, so making also the DbusMethodCalls
    to expect service in the private bus (not the default "SESSION" bus),
    is a bit more robust.
  • Another option would have been to try to dig out the session bus
    address from the running dbus-daemon process in the Ubuntu 22.04.03
    instance, and set DBUS_SESSION_BUS_ADDRESS to that, but that would be
    perhaps a bit more involved task. In addition, not all GitHub Actions
    instances have the dbus-daemon running as session bus (for example,
    the Ubuntu 20.04), so we would had to create a new bus anyway with
    dbus-daemon.

@fohrloop fohrloop merged commit 07a6075 into dev Jan 14, 2024
2 checks passed
@fohrloop
Copy link
Owner Author

@fohrloop fohrloop deleted the issue-157-dbus-adapter-tests-github-actions branch January 14, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant