Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When no project is detected, add an "open folder" button. #7707

Open
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

rrousselGit
Copy link
Contributor

@rrousselGit rrousselGit commented Sep 21, 2024

Description

The new button relies on the VSCode's built-in open command.

Screenshot 2024-09-21 at 16 49 00

Scenarios Tested

Sample Commands

hlshen and others added 30 commits September 11, 2024 16:06
* update cli support for toolkit and webhooks

* update ports

* update ports

* Replace any with Options

* update exec to call webhook, format

* address comment

* address comment

* remove unused var

---------

Co-authored-by: joehan <joehanley@google.com>
* update cli support for toolkit and webhooks

* update ports

* update ports

* Replace any with Options

* update exec to call webhook, format

* address comment

* address comment

* remove unused var

* vscode implementation of emulator start

* delete debug log

* address comments

---------

Co-authored-by: joehan <joehanley@google.com>
* Hacking away at pglite+dataconnect emulator

* Hacking away at it

* More debugging

* I THINK IT WORKSSSSS

* Saving my progress at EoD

* --amend

* Progress

* clean up

* formatting

* Use extended query patch (thanks @gregnr!)

* Format and merge master

* PR fixes

* Remove JSON comments

* format

* Fxing test compilation issues

* Cleaning up build issues

* PR fixes

* Format and generate json schema

* Patching in missing types for VSCode builds

* More type fixing

* More type fixing

* Little bit mroe code review

* Removed unused dep

* More pr fixes

* test:emualtors build fixed

* PR fixes

* Fix port disagreement
* fix webhooks and cleanup old emulator code

* await sendVSCode completion
* Clean up extension configuration

* pulls out messages into i10n/markdown-compatible source

* Simplify the config getter

* Remove errant firebase-path
* Add firebase-path option for vscode

Allow folks to specify a specific firebase binary

* Update vscode port
* cleaning up localconnectionstring

* LocalConnectionString is dead

* test fix

* Good catch
* Rough pass on extension UI

* Update docs UI

* Flex the panels to get full-width content
Created using spr 1.3.6-beta.1
* Round 1 of bug bash fixes

* Fixing build issue

* Fix package-lock.json

* Oops

* Use lsofi instead of rolling our own

* format
…ate (#7682)

* Add handling for port conflicts. Add fallback for emulator loading state

* update equality

* address comments
)

* Set default state for sidebar. Update fallback for emulator start

* address comments

* small text update

* change comment
#7691)

* WIP - better error handlingport conflicts

* Void

* Update src/emulator/storage/rules/runtime.ts

Co-authored-by: Yuchen Shi <yuchenshi@google.com>

* Update src/emulator/downloadableEmulators.ts

Co-authored-by: Yuchen Shi <yuchenshi@google.com>

* Find open ports

---------

Co-authored-by: Yuchen Shi <yuchenshi@google.com>
* update emulator reset text

* update text
Base automatically changed from launch.fdc-pp to master September 23, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants