Upgrade to Node 20 and npm deps #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DiegoRBaquero
commented
Jan 17, 2024
DiegoRBaquero
commented
- Upgrade node
- Upgrade deps
added 2 commits
January 17, 2024 10:19
DiegoRBaquero
requested review from
joaosa,
hannahhoward,
guanzo and
AmeanAsad
|
@DiegoRBaquero a few of these dep upgrades are major version upgrades. Just wanted to double check that our test cases are good enough to catch any regressions due to breaking changed in those upgrades? |
|
@AmeanAsad They are not good enough, but I did went and checked each major release notes to check there's nothing breaking |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.