Resolve registry auth URL by registry ID. Fixes issue #1688.

[wajda]

fixes #1688

When registry is Docker Hub the authentication URL should be exactly "https://index.docker.io/v1/".
This PR adds a private method getRegistryUrl to the AuthConfig class that resolves authentication URL for the given registry ID.

This PR is related to the PR #1578.

[rohanKanojia]

@wajda : Thanks for the PR. Could you please add some test to validate this fix?

[codecov]

Codecov Report

Merging #1694 (7d25453) into master (6eeb78a) will increase coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 7d25453 differs from pull request most recent head 8b94b86. Consider uploading reports for the commit 8b94b86 to get more accurate results

@@             Coverage Diff              @@
##             master    #1694      +/-   ##
============================================
+ Coverage     64.01%   64.03%   +0.01%     
- Complexity     2198     2200       +2     
============================================
  Files           171      171              
  Lines          9985     9989       +4     
  Branches       1371     1371              
============================================
+ Hits           6392     6396       +4     
  Misses         3058     3058              
  Partials        535      535              

Impacted Files	Coverage Δ
...ava/io/fabric8/maven/docker/access/AuthConfig.java	100.00% <100.00%> (ø)

[wajda]

@wajda : Thanks for the PR. Could you please add some test to validate this fix?

Sure, done.

[wajda]

@rohanKanojia can you approve workflows please?

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

[wajda]

I'm not sure why the test on Java 8 on Windows fails. I guess it's not related to this PR. Can you check please?

Error:  Tests run: 1, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0.094 s <<< FAILURE! - in io.fabric8.maven.docker.assembly.TrackArchiverCollectionTest
Error:  multipleAssemblies  Time elapsed: 0.094 s  <<< FAILURE!
org.opentest4j.AssertionFailedError: expected: <1> but was: <0>
	at io.fabric8.maven.docker.assembly.TrackArchiverCollectionTest.multipleAssemblies(TrackArchiverCollectionTest.java:57)

[wajda]

Hi team, @rohanKanojia,
Can you suggest when approximately this PR can be merged and a new release published on Maven central?
It's blocking some work on my side, and I'm wondering if I should wait or proceed with my fork. The first option is more preferred as my POM with this plugin is shared, but having to switch to my version would mean changing "groupId" which I'd like to avoid.
Thank you.

[rohanKanojia]

@wajda : Thanks for your PR!

Let me try to cut a new release this weekend. Thanks for your patience 🙏

[rohanKanojia]

@wajda : Hi, I just released v0.43.1 to maven central. Could you please test it and provide feedback whenever you get time?

[wajda]

@wajda : Hi, I just released v0.43.1 to maven central. Could you please test it and provide feedback whenever you get time?

It works as expected. Thank you @rohanKanojia and have a nice weekend!