Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: Not a JSON Array: null #1691

Merged
merged 3 commits into from
Jul 28, 2023
Merged

FIX: Not a JSON Array: null #1691

merged 3 commits into from
Jul 28, 2023

Conversation

panpengfei21
Copy link
Contributor

@panpengfei21 panpengfei21 commented Jul 7, 2023 •
edited by rohanKanojia
Loading

Fix #1690

when "RepoTags" that is from "docker inspect" is null, check it.

@panpengfei21
FIX: Not a JSON Array: null
ea6d173 
when "RepoTags" that is from "docker inspect" is null, check it.
@rohanKanojia
Copy link
Member

@panpengfei21 : Thanks for quick PR 👍 . Is it possible to write a test case validating this fix?

@panpengfei21
Copy link
Contributor Author

@panpengfei21 : Thanks for quick PR 👍 . Is it possible to write a test case validating this fix?

OK

@codecov
Copy link

codecov bot commented Jul 11, 2023 •
edited
Loading

Codecov Report

Merging #1691 (66a2c40) into master (6eeb78a) will increase coverage by 0.08%.
Report is 3 commits behind head on master.
The diff coverage is 86.66%.

❗ Current head 66a2c40 differs from pull request most recent head 3c2db68. Consider uploading reports for the commit 3c2db68 to get more accurate results

@@             Coverage Diff              @@
##             master    #1691      +/-   ##
============================================
+ Coverage     64.01%   64.09%   +0.08%     
- Complexity     2198     2205       +7     
============================================
  Files           171      171              
  Lines          9985     9994       +9     
  Branches       1371     1372       +1     
============================================
+ Hits           6392     6406      +14     
+ Misses         3058     3051       -7     
- Partials        535      537       +2
Files Changed Coverage Δ
...ven/docker/access/hc/DockerAccessWithHcClient.java 30.84% <50.00%> (+1.57%) ⬆️
...ava/io/fabric8/maven/docker/access/AuthConfig.java 100.00% <100.00%> (ø)
...bric8/maven/docker/access/ContainerHostConfig.java 92.79% <100.00%> (+0.13%) ⬆️

... and 1 file with indirect coverage changes

@sonarcloud
Copy link

sonarcloud bot commented Jul 28, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

75.0% 75.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@rohanKanojia rohanKanojia merged commit 28c54ef into fabric8io:master Jul 28, 2023
8 of 9 checks passed
@rohanKanojia
Copy link
Member

@panpengfei21 : Hi, I just released v0.43.1 to maven central. Could you please check test it and provide feedback whenever you get time?

@panpengfei21
Copy link
Contributor Author

@panpengfei21 : Hi, I just released v0.43.1 to maven central. Could you please check test it and provide feedback whenever you get time?

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Not a JSON Array: null
2 participants
@panpengfei21 @rohanKanojia