Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused ert_test_context #930

Merged
merged 2 commits into from
Nov 8, 2023

Conversation

eivindjahren
Copy link
Collaborator

@eivindjahren eivindjahren commented Nov 8, 2023

Since importing the file in question has raised an ImportError since 3.0 and will continue to raise an ImportError, but with a different message since deletion, there is no need for a major version increment because of this change.

Copy link
Contributor

@sondreso sondreso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will you give it a slightly better commit title? The "broken so likely unused" can be moved to the body I think 🙂

@eivindjahren
Copy link
Collaborator Author

Will you give it a slightly better commit title? The "broken so likely unused" can be moved to the body I think 🙂

Can do

Attempting to use this file has given an import error
for a long while without anyone complaining so it is
not used.
@eivindjahren eivindjahren changed the title Remove broken so likely unused ert_test_context Remove unused ert_test_context Nov 8, 2023
@eivindjahren eivindjahren merged commit e697e5f into equinor:main Nov 8, 2023
12 of 13 checks passed
@eivindjahren eivindjahren deleted the remove_broken_ert_test branch November 8, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants