Build and test wheels for x86_64 & arm64 #102
Conversation
andreas-el
force-pushed
the
work_on_carolina_build
branch
23 times, most recently
from
4273109
to
840d9c1
Compare
andreas-el
changed the title
|
|
||
| jobs: | ||
| build_dependencies: | ||
| strategy: | ||
| fail-fast: true | ||
| fail-fast: false |
There was a problem hiding this comment.
was this intended for dev or production?
There was a problem hiding this comment.
This made most sense when developing, but I see why it would make more sense to do a full stop if something fails in production. Lets flip this to true.
| fi | ||
| python --version | ||
|
|
||
| export PYTHON_EXECUTABLE=$(which python3) |
There was a problem hiding this comment.
I think I wrote this python3 originally for some reason, but does it maybe make sense to just write python instead of python3 here, if it has the same effect? Since we are sourcing the venv which is python3 anyway.
| export _PYTHON_HOST_PLATFORM="macosx-11.0-$arch_ver" | ||
| export ARCHFLAGS="-arch $arch_ver" | ||
|
|
||
| if [ "$arch_ver" == "arm64" ]; then |
There was a problem hiding this comment.
Suppose this is necessary to make it work, when/if GH actions change their runner/arch combinations, will this still hold up?
There was a problem hiding this comment.
The tools actually update the version number in the host platform, so this hints to the wheel build that we don't want universal wheels, but rather arm64 or x86_64 wheels separate.
I will add a comment to this since the next person won't know these details.
andreas-el
force-pushed
the
work_on_carolina_build
branch
from
840d9c1
to
281e2a7
Compare
No description provided.