fix: preventing the summing of two error terms in FeederDrtUtilityEst… #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DefaultFeederDrtUtilityEstimatorproposed as part of the Feeder functionality in PR #206 just separates the segments resulting from the main router (PT) and the access egress router (DRT) and delegates to the respective utility estimators and then sums the whole. However when using the Epsilon functionality, this results in the error terms of each sub-estimator to be summed before adding the error term of the feeder mode on top of that.This PR fixes this by checking whether the estimators are instances of
EpsilonAdapterand unwraps the base estimator behind them.