-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apiSupported
property
#30
base: master
Are you sure you want to change the base?
Add apiSupported
property
#30
Conversation
* Add `apiSupported` property that indicates whether Geolocation API is supported or not. * Update code and descriptions of samples in `geo-location.html`, `demo/index.html` and `README.md` files. * Remove `version` field in `bower.json` file, because it's deprecated and ignored by Bower (https://github.com/bower/spec/blob/master/json.md#version). * Add `polymer-element`, `polymer-2` and `polymer-2-hybrid` keywords to `bower.json` file to indicate that this is Polymer 1.x/2.x hybrid element.
@ebidel PTAL. |
@@ -38,6 +44,16 @@ | |||
|
|||
properties: { | |||
/** | |||
* Indicates whether `Geolocation API` is supported or not. | |||
*/ | |||
apiSupported: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about just supported
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebidel IMO, api-supported
is more clear than just supported
. Many web components use api-supported
, e.g.:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fair enough
Please add a test. |
What do you mean? |
Add a test case: https://github.com/ebidel/geo-location/tree/master/test |
apiSupported
property that indicates whether Geolocation API is supported or not.geo-location.html
,demo/index.html
andREADME.md
files.version
field inbower.json
file, because it's deprecated and ignored by Bower (https://github.com/bower/spec/blob/master/json.md#version).polymer-element
,polymer-2
andpolymer-2-hybrid
keywords tobower.json
file to indicate that this is Polymer 1.x/2.x hybrid element.