new zip coefficents for loads #2391
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unpp got updated aswell
|
I see that you also have a build (3.11, 1) failure. Here I described the reason for the test failure: |
|
yeah, looks strange to me also. We made some changes to the mpc and ppc converters recently in PR #2347, but this bug didn't appear back then... Will let you know if we find out something |
|
I had a local test that was skipped because of the decorator (as far as I understand, if And I also think we need to look at when the migration to numpy 2.0 took place. Perhaps earlier versions weren't so strict. |
… format works fine. Should be replaced before release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pandapower the zip coefficients
const_i_percentandconst_z_percentwere defined both for the P and the Q voltage dependency of loads. This PR separates them and introducesconst_i_p_percent,const_i_q_percent,const_z_p_percent,const_z_q_percentto allow separate P and Q voltage dependecies in the power flow.const_i_percentandconst_z_percentare replaced with these new columns.