Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that pypower.opf cannot be called with small pypower format #2383

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

SimonUlm
Copy link

Issue

When calling pypower.opf() directly on data stored as ppc, the function might fail if the ppc has the wrong number of columns (e.g. when converted from a m. file using _m2ppc). This is supposed to be prevented by adding zero columns in opf.py. However, the added number of columns does not match the size of the current ppc format.

Fixed

  • Increased number of columns in bus, such that it covers every possible ppc format
  • Moved the adding of zero columns to opf_args.py
  • Updated numbers of columns to be added

@SimonUlm SimonUlm marked this pull request as ready for review August 28, 2024 13:43
Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.04%. Comparing base (be0f2cf) to head (6d5b0f5).
Report is 32 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2383   +/-   ##
========================================
  Coverage    76.04%   76.04%           
========================================
  Files          281      281           
  Lines        32798    32794    -4     
========================================
- Hits         24940    24938    -2     
+ Misses        7858     7856    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SimonUlm SimonUlm force-pushed the fix/fix-opf-with-old-ppc-format branch from 6d5b0f5 to 7d7696d Compare August 30, 2024 10:04
@SimonUlm
Copy link
Author

Hi,
I noticed that some tests were failing. However, the failing tests in test_pandamodels_runpm.py also fail on my local machine on the develop branch. Is this a known issue or is there something I am doing wrong (this is my first MR to this project)?

@SimonUlm SimonUlm force-pushed the fix/fix-opf-with-old-ppc-format branch from 7d7696d to cc4c2bc Compare September 18, 2024 14:04
@SimonUlm SimonUlm force-pushed the fix/fix-opf-with-old-ppc-format branch from cc4c2bc to 6ca1849 Compare September 18, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant