Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/kmskeyrotation #27

Open
wants to merge 23 commits into
base: dev
Choose a base branch
from
Open

Feature/kmskeyrotation #27

wants to merge 23 commits into from

Conversation

oleksii-dowjones
Copy link
Contributor

No description provided.

Macharla, Vigneswararao and others added 13 commits October 9, 2018 10:17
Updated with KMS key rotation changes.
480beea 
Updated with KMS key rotation changes.
Code changes for deployment issues in KMS.
70eeba0 
Code changes for deployment issues in KMS.
Modified with deployment issues for KMS
e043891 
Modified with deployment issues for KMS key rotation issues.
Updated with deployment issues.
003744b 
Updated with deployment issues.
Updated with deployment issues.
ca75fca 
Updated with deployment issues.
Updated with permissions
c378d3f 
Updated with permissions
Updated with KMS changes.
6caf84f 
Updated with KMS changes.
Updated with Kms key rotation changes.
ac6438d 
Updated with Kms key rotation changes.
@vigneswararaomacharla
Modified with kms key rotation config changes.
ed1cf51 
Modified with kms key rotation config changes.
@vigneswararaomacharla
Updated with config changes.
83fc9e5 
Updated with config changes.
@oleksii-dowjones
Add fixes
f45cd88 
In this commit:
1) Check region of open issues during identification, so no issues in another regions
will be closed.
2) Remove extra DDB tables.
3) If issue chacking fails in specific region, proceed with checking in other regions.
4) Reuse convert_tags utility function
@oleksii-dowjones
Merge branch 'dev' into feature/kmskeyrotation
69c08ed
@oleksii-dowjones
Add remediation and reporting scripts to scheduler
3fe41a7 
Add KMS reporting and remediation scripts to scheduler
@paleg-dj paleg-dj removed their assignment Dec 14, 2018
paleg-dj
paleg-dj approved these changes Dec 17, 2018
View reviewed changes
Copy link
Contributor

@paleg-dj paleg-dj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed and tested in lab account, looks okay.

@paleg-dj
Copy link
Contributor

@vigneswararaomacharla , please add documentation for this feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paleg-dj paleg-dj paleg-dj approved these changes

Assignees

@pranav1688 pranav1688

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oleksii-dowjones @paleg-dj @pranav1688 @vigneswararaomacharla @paleg