fix: use proper context instead of activity #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Samuel pointed out in this issue the createClient currently might fail if there is no activity launched yet. This can happen especially on apps making use of Android Auto since that runs on a service only and has no activity.
This PR makes use of the reactContext that is passed when creating an instance of BlePlxModule so there should be a valid context all the time now.
@dimninik you changed that a while ago, do you remember why you came up with this solution to use the activity instead of the reactContext? c610878#diff-a1a97970184ebc2e5a60c771e7f36d7679d4977f1232a0f9247a77957c707a39R87