🐛 Fix issue where moving mouse over command button after leaving woul…

…d fire command
dothq · Dec 21, 2023 · 8164dd5 · 8164dd5
1 parent ff168c5
commit 8164dd5
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/components/commands/widgets/browser-command-button.js b/components/commands/widgets/browser-command-button.js
@@ -107,7 +107,10 @@ class BrowserCommandButton extends BrowserButton {
 			if (!isAllowedInput) return;
 		}
 
-		if (isMousedown) event.preventDefault();
+		if (isMousedown) {
+			event.preventDefault();
+			event.stopPropagation();
+		}
 
 		if (event.type == "mouseleave") {
 			window.addEventListener(
@@ -122,9 +125,10 @@ class BrowserCommandButton extends BrowserButton {
 					/** @type {KeyboardEvent} */ (event).code
 				);
 
-			this.toggleAttribute("mouseactive", isMousedown || isKeydown);
+			const canCommand =
+				(this.hasAttribute("mouseactive") && isMouseup) || isKeydown;
 
-			const canCommand = isMouseup || isKeydown;
+			this.toggleAttribute("mouseactive", isMousedown || isKeydown);
 
 			if (canCommand) {
 				this._doCommand.call(this, event);