Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

컨벤션 반영 #41

Closed
wants to merge 3 commits into from
Closed

Conversation

leeminhee119
Copy link
Member

컨벤션 반영


🏄🏼‍♂️‍ Summary (요약)

  • 컴포넌트 named export
  • 컴포넌트 함수 선언문
  • 공통 컴포넌트 index 파일 추가
  • 폴더명 카멜케이스

🫨 Describe your Change (변경사항)

🧐 Issue number and link (참고)

📚 Reference (참조)

@leeminhee119 leeminhee119 added the 🧹 refactor 사용자에게는 드러나지 않는 코드 상의 변화 label Jul 15, 2024
@leeminhee119 leeminhee119 self-assigned this Jul 15, 2024
@@ -13,6 +13,7 @@
"isolatedModules": true,
"noEmit": true,
"jsx": "react-jsx",
"forceConsistentCasingInFileNames": true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

엇 이거 넣으면 파일 명에 변화가 생기는건가?!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아 요게 계속 폴더 대소문자를 구분 못해서 넣어봤는데 파일명 한정어서인지 해도 안되네
근데 이게 내 깃이 대소문자를 구분 못하고 있어서 그랬던 거 같아서 깃 설정하고 새로 브랜치 파서 다시 pr 올릴게!

@leeminhee119
Copy link
Member Author

#44

@klmhyeonwoo klmhyeonwoo deleted the refactor/28/conventions-minhee branch August 15, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 refactor 사용자에게는 드러나지 않는 코드 상의 변화
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants