feat(memo): 메모 API 구현 #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collection50
requested review from
qkrdmstlr3,
woo-jk and
eunbeann
as code owners
Collection50
commented
Aug 17, 2024
Comment on lines
+31
to
+37
| useEffect(() => { | ||
| adjustTextareaHeight(); | ||
|
|
||
| if (prevMemo.current !== memo) { | ||
| putMemo({ memoId, content: memo }); | ||
| } | ||
| }, [memo]); |
There was a problem hiding this comment.
ref를 활용해, 이전값과 memo가 달라지는 경우에만 API를 호출하도록 했습니다.
Comment on lines
+174
to
+178
| <AsyncBoundaryWithQuery> | ||
| <MemosFetcher cardId={cardId}> | ||
| <MemoContainer /> | ||
| </MemosFetcher> | ||
| </AsyncBoundaryWithQuery> |
There was a problem hiding this comment.
부분적으로 Suspense를 사용해 UX를 향상하고자 했습니다
loading fallback이나 error fallback은 추후 작성할 예정입니다.
There was a problem hiding this comment.
바로 memoContainer를 사용하는 것이 아닌 Fetcher를 이용해서 context로 내려주는 이유가 궁금해요!
There was a problem hiding this comment.
선언적으로 데이터 페칭을 하기 위함입니다 !
context를 사용해서 props drilling 또한 해결할 수 있어요 !
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. 무슨 이유로 코드를 변경했나요?
2. 어떤 위험이나 장애를 발견했나요?
3. 관련 스크린샷을 첨부해주세요.
4. 완료 사항
5. 추가 사항 / 코드 리뷰 받고 싶은 부분