-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webmaster doc #1559
base: develop
Are you sure you want to change the base?
Webmaster doc #1559
Conversation
160ba2b
to
c76fae0
Compare
I don't know why I get those merge commits, I've just rebased on |
Try rebasing against |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Nice. I think this is well written.
There are some parts that I think needs to be addressed primarily usage of DPL and the document structure.
Please also consider if some parts actually belong in an ADR about configuration handling for custom modules for webmaster sites. This allows us to mention alternatives considered, known challenges, future perspectives etc. while this documentation only dealing with the practicalities and known processes.
b95bf8f
to
823048e
Compare
Add documentation about configuration handling in webmaster modules.