Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webmaster doc #1559

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Webmaster doc #1559

wants to merge 4 commits into from

Conversation

xendk
Copy link
Contributor

@xendk xendk commented Sep 11, 2024

Add documentation about configuration handling in webmaster modules.

@github-actions github-actions bot temporarily deployed to pr-1559 September 11, 2024 19:48 Destroyed
@github-actions github-actions bot temporarily deployed to pr-1559 September 11, 2024 19:49 Destroyed
@xendk
Copy link
Contributor Author

xendk commented Sep 11, 2024

I don't know why I get those merge commits, I've just rebased on origin/main.

@kasperg
Copy link
Contributor

kasperg commented Sep 12, 2024

I don't know why I get those merge commits, I've just rebased on origin/main

Try rebasing against develop 😄. These are merge requests from develop into main. The PR is against develop.

Copy link
Contributor

@kasperg kasperg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice. I think this is well written.

There are some parts that I think needs to be addressed primarily usage of DPL and the document structure.

Please also consider if some parts actually belong in an ADR about configuration handling for custom modules for webmaster sites. This allows us to mention alternatives considered, known challenges, future perspectives etc. while this documentation only dealing with the practicalities and known processes.

docs/webmaster-modules.md Outdated Show resolved Hide resolved
docs/webmaster-modules.md Outdated Show resolved Hide resolved
docs/webmaster-modules.md Outdated Show resolved Hide resolved
docs/webmaster-modules.md Outdated Show resolved Hide resolved
docs/webmaster-modules.md Outdated Show resolved Hide resolved
docs/webmaster-modules.md Outdated Show resolved Hide resolved
docs/webmaster-modules.md Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-1559 September 13, 2024 09:47 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants