Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update+Patch recurring_events. DDFFORM-877 #1486

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

rasben
Copy link
Contributor

@rasben rasben commented Aug 15, 2024

Updating the module, means that some of the upstream patches have been merged.
This commit also adds a new upstream patch, made by us. The patch fixes it, so the editor can create events that start at 00:00.

https://www.drupal.org/project/recurring_events/issues/3468300

Description of patch:

Up until now, the min_time/max_time in the settings form, are just text fields, that take data in AM/PM.
This is problematic, because the code that parses it, fails when an editor has inserted "00:00".
This commit changes the form to instead use time inputs, and ports any existing data to the new format.
This also makes the new format 24h instead of 12h.

Link to issue

https://reload.atlassian.net/browse/DDFFORM-877

@github-actions github-actions bot temporarily deployed to pr-1486 August 15, 2024 10:55 Destroyed
Updating the module, means that some of the upstream patches have been
merged.
This commit also adds a new upstream patch, made by us.
The patch fixes it, so the editor can create events that start at 00:00.
@github-actions github-actions bot temporarily deployed to pr-1486 August 15, 2024 11:03 Destroyed
Copy link
Contributor

@xendk xendk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@rasben rasben added don't merge PR not ready for merge (could be dependent on other PR) and removed jira-testable ready for DDF test, and moved in Jira labels Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
don't merge PR not ready for merge (could be dependent on other PR)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants