Merge pull request #436 from danielgtaylor/fix-cli-test-race

fix: race condition in CLI tests
danielgtaylor · May 11, 2024 · e089398 · e089398
2 parents 992a33d + 2ff5002
commit e089398
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/humacli/humacli_test.go b/humacli/humacli_test.go
@@ -202,11 +202,11 @@ func TestCLICommandWithOptions(t *testing.T) {
 func TestCLIShutdown(t *testing.T) {
 	type Options struct{}
 
-	started := false
+	started := make(chan bool, 1)
 	stopping := make(chan bool, 1)
 	cli := humacli.New(func(hooks humacli.Hooks, options *Options) {
 		hooks.OnStart(func() {
-			started = true
+			started <- true
 			<-stopping
 		})
 		hooks.OnStop(func() {
@@ -221,7 +221,7 @@ func TestCLIShutdown(t *testing.T) {
 
 	cli.Root().SetArgs([]string{})
 	cli.Run()
-	assert.True(t, started)
+	assert.True(t, <-started)
 }
 
 func TestCLIBadType(t *testing.T) {