Added support for enabling TLS and handling server CA cert. #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ezgidemirel
reviewed
Aug 2, 2023
|
Hello @hasheddan & @Feggah I am following up on this PR on behalf of the author who is my teammate and who is on vacation. I think with the announcement the other day, upbound devs no longer contributing to community providers, this PR went into limbo as the only reviewer so far was @ezgidemirel. If/when you have a moment would you please provide a review? |
andrewj-a42
force-pushed
the
master
branch
2 times, most recently
from
e21a4f8
to
aba20c7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
The change is adding support for enabling 'SERVER_AUTHENTICATION' for the TransitEncryptionMode.
The code is setting the value of TransitEncryptionMode field for gcp client and is observing serverCACerts field.
As soon as the instance is provisioned and CA is generated it is added to the managed resource to the atProvider section.
Fixes #
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
This code was tested by building a fresh image and deploying it to a dev cluster with crossplane pod up and running.
Successful cloudMemoryStore provisioning was performed and with TransitEncryptionMode field set to 'SERVER_AUTHENTICATION' value, the redis provisioning process generated server CA certificate which became part of 'atProvider' section of the managed resource.