Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement/redis intransitenription #490

Closed
wants to merge 3 commits into from
Closed

Enhancement/redis intransitenription #490

wants to merge 3 commits into from

Conversation

andrewj-a42
Copy link
Contributor

@andrewj-a42 andrewj-a42 commented Feb 8, 2023

Description of your changes

he change is to enable support for InTransitEncription of redis memorycloudstore.
This property is already supported by used gcp redis client.

Changes include:

  • added TransitEncryptionMode parameter to CloudMemorystoreInstanceParameters and CloudMemorystoreInstanceObservation structs
  • updated GenerateRedisInstance function to set value for submitted in transit encryption mode
  • added line for setting the in transit encryption mode to GenerateObservation function
  • conditionally included the in transit encryption mode in LateInitializeSpec function

Fixes #

I have:

  • Read and followed Crossplane's contribution process.
  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

…efinition; enhanced code for cloudmemorystore to read and set the value for 'GenerateRedisInstance' and 'GenerateObservation' and 'LateInitializeSpec' functions; Signed-off-by: Andrew Jakubowski <a.jakubowski@sap.com>
@andrewj-a42
Copy link
Contributor Author

This implementation is incomplete, closing the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant