ACC Setdevice reordering #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. I like the Bonus too. Instead of reviewing the code line-by-line, I will test it on a multi-GPU system and see if #591 is resolved. |
|
I am working on |
hfp
approved these changes
Mar 25, 2022
|
I can confirm, this PR resolves #591. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setdevice is now called as part of acc_init. This problem was introduced with eb1c268
It is forbidden to change the device during the DBCSR execution by design, so acc_init is the correct place where to call setdevice
This PR should fix ACC: orphaned context causing multi-gpu issue #591
We still have some of the problems discussed in ACC init/finalize issues #422 , we use another PR for that...
Bonus: I'm commenting acc tests on because of tests: make libsmm_acc tests run with MPI #427