Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

24-host: Reduce provable surface area to only packet flow keys #1144

Open
wants to merge 7 commits into
base: feat/v2-spec
Choose a base branch
from
Open

24-host: Reduce provable surface area to only packet flow keys #1144

wants to merge 7 commits into from

Conversation

AdityaSripal
Copy link
Member

@AdityaSripal AdityaSripal commented Aug 21, 2024 •
edited
Loading

  • Removes connection/channel keys
  • Client keys are now private since they aren't proven by counterparty
  • Keeps key paths and values the same for now
  • Add counterparty key/value to private store
  • Remove self client validation necessity

Closes: #1138

crodriguezvega
crodriguezvega approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@crodriguezvega crodriguezvega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

spec/core/v2/ics-024-host-requirements/README.md
@@ -311,16 +186,6 @@ This permissioning can be implemented with unique references (object capabilitie

Modules that wish to make use of particular IBC features MAY implement certain handler functions, e.g. to add additional logic to a channel handshake with an associated module on another state machine.

### Datagram submission
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious: why was this section deleted?

sangier
sangier approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@sangier sangier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great simplification!!! If you merge latest change from feat/v2-spec you should be able to get rid of the CI failures.

@AdityaSripal
Copy link
Member Author

Leaving open for now because we may want to remove specification of private keys entirely. it is up to individual implementations to decide how best to execute the logic required to write the provable keys in store.

Also, we should be standardizing the values stored under the provable keys in this specification as well.

Also blocked on discussion around spec format. i.e. ABI for universal data format and moving to IETF standards for specs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sangier sangier sangier approved these changes

@crodriguezvega crodriguezvega crodriguezvega approved these changes

@angbrav angbrav Awaiting requested review from angbrav angbrav is a code owner

@colin-axner colin-axner Awaiting requested review from colin-axner colin-axner is a code owner

@damiannolan damiannolan Awaiting requested review from damiannolan damiannolan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdityaSripal @crodriguezvega @sangier