Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge error-handling branch into main #1350

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [ibc-core] Defined a new `HostError` type in ics24 to draw distinction between protocol errors and host errors
([\1320](https://github.com/cosmos/ibc-rs/issues/1320))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [ibc-core-channel] Merge `PacketError` type into `ChannelError`
([#1339](https://github.com/cosmos/ibc-rs/pull/1343))
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- [ibc-core] Remove `ClientError::Other` variant
([\#1346](https://github.com/cosmos/ibc-rs/issues/1346))
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
- Modify `validate_self_client` error type to return `ContextError` instead of
`ConnectionError`
([#482](https://github.com/cosmos/ibc-rs/issues/482))
- Modify `validate_self_client` error type to return `HostError` instead of
`ConnectionError`
([#482](https://github.com/cosmos/ibc-rs/issues/482))
2 changes: 1 addition & 1 deletion .changelog/v0.33.0/improvement/547-error-strings.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
- Fix ContextError Display output
- Fix HandlerError Display output
([#547](https://github.com/cosmos/ibc-rs/issues/547))
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
- Allow hosts to handle overflow cases in `increase_*_counter` methods by
returning `Result<(),ContextError>` type.
returning `Result<(),HostError>` type.
([#857](https://github.com/cosmos/ibc-rs/issues/857))
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
- logger and event emitter methods return `Result<(), ContextError>` type.
- logger and event emitter methods return `Result<(), HostError>` type.
([#859](https://github.com/cosmos/ibc-rs/issues/859))
8 changes: 4 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -641,9 +641,9 @@ There are no consensus-breaking changes.
- Bump ibc-proto-rs to v0.34.0
([#790](https://github.com/cosmos/ibc-rs/issues/790))
- Allow hosts to handle overflow cases in `increase_*_counter` methods by
returning `Result<(),ContextError>` type.
returning `Result<(),HandlerError>` type.
([#857](https://github.com/cosmos/ibc-rs/issues/857))
- logger and event emitter methods return `Result<(), ContextError>` type.
- logger and event emitter methods return `Result<(), HandlerError>` type.
([#859](https://github.com/cosmos/ibc-rs/issues/859))
- Bump `ibc-proto-rs` to v0.35.0 along with some other minor dependency updates
([#873](https://github.com/cosmos/ibc-rs/issues/873))
Expand Down Expand Up @@ -1042,7 +1042,7 @@ There are no consensus-breaking changes.

### IMPROVEMENT

- Fix `ContextError` Display output
- Fix `HandlerError` Display output
([#547](https://github.com/cosmos/ibc-rs/issues/547))

## v0.32.0
Expand Down Expand Up @@ -1099,7 +1099,7 @@ There are no consensus-breaking changes.
([#479](https://github.com/cosmos/ibc-rs/issues/479))
- Remove Send + Sync supertraits on the Module trait
([#480](https://github.com/cosmos/ibc-rs/issues/480))
- Modify `validate_self_client` error type to return `ContextError` instead of
- Modify `validate_self_client` error type to return `HandlerError` instead of
`ConnectionError`
([#482](https://github.com/cosmos/ibc-rs/issues/482))

Expand Down
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ ibc-client-wasm-types = { version = "0.54.0", path = "./ibc-clients/ics08-
ibc-app-transfer-types = { version = "0.54.0", path = "./ibc-apps/ics20-transfer/types", default-features = false }
ibc-app-nft-transfer-types = { version = "0.54.0", path = "./ibc-apps/ics721-nft-transfer/types", default-features = false }

ibc-proto = { version = "0.47.0", default-features = false }
ibc-proto = { version = "0.47.1", default-features = false }

# cosmos dependencies
tendermint = { version = "0.38.0", default-features = false }
Expand Down
6 changes: 4 additions & 2 deletions ci/cw-check/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading