unpack ICS008 wasm client state at ConnOpenTry and ConnOpenAck #1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
=======================================
Coverage 67.25% 67.26%
=======================================
Files 234 235 +1
Lines 23478 23516 +38
=======================================
+ Hits 15791 15817 +26
- Misses 7687 7699 +12 ☔ View full report in Codecov by Sentry. |
rnbguy
force-pushed
the
rano/allow-country-party-client-state-wrapper
branch
from
67841b3
to
268fcab
Compare
rnbguy
force-pushed
the
rano/allow-country-party-client-state-wrapper
branch
from
9374a29
to
8a2b25f
Compare
rnbguy
force-pushed
the
rano/allow-country-party-client-state-wrapper
branch
from
fb354e4
to
c8c97fc
Compare
seanchen1991
approved these changes
Jun 5, 2024
rnbguy
added a commit
that referenced
this pull request
Jun 5, 2024
* add GAT for ClientStateWrapperAtAnyCounterParty * add trait bounds * unwrap expecting a client state wrapper * fix test * rm trait bound * rm Into::into * validate_self_client takes wrapped client_state * nit on trait method types * revert logic * unpack wasm client on wasm client id * add tests for is_wasm_client_id * add trait bounds * add prost dep * successful compilation * impl fn to unpack host client state * update cargo lockfiles for ci * fix no_std import * fix is_wasm_client_id * fix comment * add changelog entry * doc-comment for unpack_host_client_state * use constant for wasm client-id prefix
This was referenced Jun 6, 2024
rnbguy
changed the title
rnbguy
changed the title
Farhad-Shabani
pushed a commit
that referenced
this pull request
Sep 9, 2024
* add GAT for ClientStateWrapperAtAnyCounterParty * add trait bounds * unwrap expecting a client state wrapper * fix test * rm trait bound * rm Into::into * validate_self_client takes wrapped client_state * nit on trait method types * revert logic * unpack wasm client on wasm client id * add tests for is_wasm_client_id * add trait bounds * add prost dep * successful compilation * impl fn to unpack host client state * update cargo lockfiles for ci * fix no_std import * fix is_wasm_client_id * fix comment * add changelog entry * doc-comment for unpack_host_client_state * use constant for wasm client-id prefix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1237
Description
PR author checklist:
unclog.docs/).Reviewer checklist:
Files changedin the GitHub PR explorer.