Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Enable derive feature of parity-scale-codec #1238

Merged
merged 2 commits into from
May 24, 2024

Conversation

seanchen1991
Copy link
Contributor

@seanchen1991 seanchen1991 commented May 24, 2024

Closes: #1124

Description


PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@seanchen1991 seanchen1991 changed the title chore(deps): Enable derive feature of parity-scale-code chore(deps): Enable derive feature of parity-scale-codec May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.56%. Comparing base (2378cd4) to head (0c41355).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1238   +/-   ##
=======================================
  Coverage   65.56%   65.56%           
=======================================
  Files         234      234           
  Lines       23519    23519           
=======================================
  Hits        15421    15421           
  Misses       8098     8098           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ! 👍

@seanchen1991 seanchen1991 added this pull request to the merge queue May 24, 2024
Merged via the queue into main with commit dcf8c36 May 24, 2024
19 checks passed
@seanchen1991 seanchen1991 deleted the deps/update-parity-scale branch May 24, 2024 20:59
Farhad-Shabani pushed a commit that referenced this pull request Sep 9, 2024
* Update parity-scale-codec depdendency in cargo.toml

* Run taplo format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the feature list of parity-scale-codec dependency
2 participants