Skip to content

Commit

Permalink
Incorporate some PR feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
seanchen1991 committed Sep 17, 2024
1 parent 3b6e6b6 commit 9942007
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
- [ics04-channel] Merge `PacketError` type into `ChannelError`
- [ibc-core-channel] Merge `PacketError` type into `ChannelError`
([#1339](https://github.com/cosmos/ibc-rs/pull/1343))
2 changes: 1 addition & 1 deletion ibc-core/ics04-channel/types/src/channel.rs
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ impl ChannelEnd {
/// Checks if the counterparty of this channel end matches with an expected counterparty.
pub fn verify_counterparty_matches(&self, expected: &Counterparty) -> Result<(), ChannelError> {
if !self.counterparty().eq(expected) {
return Err(ChannelError::MismatchedCounterparties {
return Err(ChannelError::MismatchedCounterparty {
expected: expected.clone(),
actual: self.counterparty().clone(),
});
Expand Down
4 changes: 2 additions & 2 deletions ibc-core/ics04-channel/types/src/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@ pub enum ChannelError {
MissingCounterparty,
/// missing timeout
MissingTimeout,
/// mismatched counterparties: expected `{expected}`, actual `{actual}`
MismatchedCounterparties {
/// mismatched counterparty: expected `{expected}`, actual `{actual}`
MismatchedCounterparty {
expected: Counterparty,
actual: Counterparty,
},
Expand Down

0 comments on commit 9942007

Please sign in to comment.