chore(goversion): upgrade minimum version to 1.22 #1145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M4tteoP
commented
Sep 5, 2024
| @@ -399,7 +399,7 @@ func (r *Rule) transformArg(arg types.MatchData, argIdx int, cache map[transform | |||
| default: | |||
| // NOTE: See comment on transformationKey struct to understand this hacky code | |||
| argKey := arg.Key() | |||
| argKeyPtr := (*reflect.StringHeader)(unsafe.Pointer(&argKey)).Data | |||
| argKeyPtr := (*reflect.StringHeader)(unsafe.Pointer(&argKey)).Data // nolint:staticcheck | |||
There was a problem hiding this comment.
reflect.StringHeader has been deprecated and the linter is complaining.
Something like the following might do the trick, but I don't want to rush changes on something very hack and performance-related.
argKeyPtr := uintptr(unsafe.Pointer(unsafe.StringData(argKey)))
There was a problem hiding this comment.
Ugh, why do we need unsafe in the first place...
There was a problem hiding this comment.
This is the historical context: #553. We should revisit and see if we have some other viable option. If this looks okay, we can go ahead with merging and I'll open an issue about that
There was a problem hiding this comment.
Yes, let's upgrade the golang part and create a follow up issue.
fzipi
reviewed
Sep 5, 2024
durg78
added a commit
to durg78/coraza
that referenced
this pull request
Sep 6, 2024
chore(goversion): upgrade minimum version to 1.22 (corazawaf#1145)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Go 1.23is out, so as per our policy, we should be fine supportinggo 1.22andgo 1.23:Note: It should also unblock #1089, which requires go >= 1.22