Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #284: make gtest an external dependency AND upgrade gtest 1.10.0 -> 1.12.1 #285

Closed

Conversation

defaultbranch
Copy link
Contributor

@defaultbranch defaultbranch commented Aug 3, 2022

Regarding issue #284 (and maybe also older issues like #233):

Please consider this pull request a suggestion and try for yourself whether it works; Caution:

  • this deletes a whole folder from the project (I believe this was copy-paste content)
  • this also upgrades from GoogleTest 1.10.0 to 1.12.x
  • and some test is failing (for me) and may need additional fixing (which I cannot provide, since I am not an Entwine developer, only a user)

@connormanning
Copy link
Owner

Might just need to update the JSON library used, because it looks like the error is not in Entwine proper but rather this issue. As to why it is only appearing now and not before, I do not know.

@defaultbranch
Copy link
Contributor Author

Ah sorry, I was working in parallel and just saw your reply now, but came to sth similar (#286; just close if redundant)

@hobu hobu mentioned this pull request Apr 27, 2023
@hobu hobu closed this Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants