Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

discussion: nlohmann's json library is heavily outdated #286

Closed
defaultbranch opened this issue Aug 3, 2022 · 1 comment
Closed

discussion: nlohmann's json library is heavily outdated #286

defaultbranch opened this issue Aug 3, 2022 · 1 comment

Comments

@defaultbranch
Copy link
Contributor

Entwine still uses a 3.6.1 copy (dating ~3 years ago) from the original author in https://github.com/connormanning/entwine/blob/master/entwine/third/mjson/json.hpp, while his current version https://github.com/nlohmann/json#cmake reached 3.11 or something.

With the evolution of C++ in the last years, this 3.6.1 version seems to have become deprecated or unsupported, depending on the compiler/build environment, and sometimes compilers don't accept the code of that version anymore.

Please consider todays https://github.com/nlohmann/json#cmake for Entwine. I hope this also helps to make the current builds and merge requests more stable;...

@connormanning
Copy link
Owner

Closed by #308.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants