Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Signup upgrade #9

Closed
wants to merge 12 commits into from
Closed

Signup upgrade #9

wants to merge 12 commits into from

Conversation

izzyjosh
Copy link
Contributor

@izzyjosh izzyjosh commented Nov 8, 2023

No changes was made just the settings.py configuration.

codewitgabi
codewitgabi requested changes Nov 8, 2023
View reviewed changes
Copy link
Owner

@codewitgabi codewitgabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For multiline comments, make sure it follows this pattern

"""
code
"""

  • Switch database to use postgres

@codewitgabi codewitgabi linked an issue Nov 9, 2023 that may be closed by this pull request
Feature: Authentication Upgrade #4
Open
codewitgabi
codewitgabi requested changes Nov 9, 2023
View reviewed changes
Copy link
Owner

@codewitgabi codewitgabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok.. this is nice.

  • Add a validator to such that the user's password must contain lowercase, uppercase and symbols.
  • Also, your database is still using sqlite3. Fix that

codewitgabi
codewitgabi requested changes Nov 11, 2023
View reviewed changes
Copy link
Owner

@codewitgabi codewitgabi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make your pull request against the dev branch

@codewitgabi codewitgabi removed a link to an issue Nov 11, 2023
Feature: Authentication Upgrade #4
Open
@codewitgabi
Copy link
Owner

PR moved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codewitgabi codewitgabi codewitgabi requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@izzyjosh @codewitgabi