[후] 스프링 카페 3단계 - DB에 저장하기 #129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheejuni
requested changes
Mar 20, 2022
| @@ -5,31 +5,46 @@ | |||
|
|
|||
| public class Article { | |||
|
|
|||
| private int id; | |||
| private String userId; | |||
| private final Integer id; | |||
There was a problem hiding this comment.
id 를 Integer 로 저장하는 것.. 괜찮을까요?
괜찮다고 쉽게 생각할 수는 있지만 권장하지는 않습니다. 왜 권장하지 않을까요?
Comment on lines
+33
to
+34
| public Article(Integer id, String userId, String title, String content, | ||
| AtomicInteger viewCount, LocalDateTime createdAt) { |
There was a problem hiding this comment.
viewCount 가 AtomicInteger 인 이유도 궁금해요.
| this.email = email; | ||
| this.userId = userId; | ||
| this.password = password; | ||
| this.createdAt = LocalDateTime.now(); | ||
| } | ||
|
|
||
| public User(int id, User user) { |
There was a problem hiding this comment.
Integer 와 int 사이에 변환이 일어날 때 생각해볼 만한 리스크는 없을까요?
| import org.springframework.stereotype.Repository; | ||
|
|
||
| @Repository | ||
| public class H2ArticleRepository implements ArticleRepository { |
There was a problem hiding this comment.
클래스명에 특정 기술/라이브러리/프레임워크가 들어가는 것에 강하게 반대합니다.
이렇게 특정 기술에 종속되지 않으려고 클래스를 나누고, 인터페이스를 분리하는 것이라고 생각합니다.
그리고 H2 와 MySQL 이 레포지토리가 달라야 하는 이유도 잘 모르겠습니다.
그 둘은 완벽하게 호환되어서 서로의 존재를 몰라도 로컬 테스트/디버깅이 용이하게끔 사용하는 목적이 있습니다.
왜 달라야 하죠?
Comment on lines
+31
to
+35
| public int save(Article article) { | ||
| if (article.isNewArticle()) { | ||
| return insert(article); | ||
| } | ||
| return update(article); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
안녕하세요! 스프링 카페 3단계 PR 요청 드립니다. 항상 감사합니다 :)
변경 사항